[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array
From: |
Fabien Chouteau |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array |
Date: |
Mon, 07 Oct 2013 15:06:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 |
On 10/07/2013 01:45 PM, Peter Maydell wrote:
> On 7 October 2013 19:11, Fabien Chouteau <address@hidden> wrote:
>> On 10/04/2013 07:49 PM, Peter Maydell wrote:
>>> On 5 October 2013 01:57, Fabien Chouteau <address@hidden> wrote:
>>>>> @@ -47,7 +48,9 @@
>>>> #include "hw/xen/xen.h"
>>>> #include "hw/i386/apic_internal.h"
>>>> #endif
>>>> +#include "monitor/monitor_def.h"
>>>>
>>>> +extern const MonitorDef i386_monitor_defs[];
>>>
>>> Declare this in cpu-qom.h, rather than having an
>>> extern declaration in a .c file.
>>>
>>
>> I didn't manage to do that.
>
> If you just say "I couldn't make that work" with no details,
> there isn't much I can say beyond "try harder" :-)
> If you say *why* you couldn't get it to work then I'm more
> likely to either (a) suggest an approach that will work or
> (b) accept that it really does have to be that way...
>
Sorry I sent the email too quickly. It looks like a circular dependency
In file included from /home/chouteau/src/qemu-main/target-arm/cpu.h:294:0,
from
/home/chouteau/src/qemu-main/include/monitor/monitor_def.h:4,
from /home/chouteau/src/qemu-main/target-arm/monitor.c:20:
/home/chouteau/src/qemu-main/target-arm/cpu-qom.h:184:25: error: array type has
incomplete element type
make[1]: *** [target-arm/monitor.o] Error 1
monitor_def.h -> cpu.h -> cpu-qom.h -.
^ |
|__________________________________/
--
Fabien Chouteau
- [Qemu-devel] [PATCH 0/4] Few minor improvements of monitor disas command (v4), Fabien Chouteau, 2013/10/04
- [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands, Fabien Chouteau, 2013/10/04
- [Qemu-devel] [PATCH 2/4] Improve Monitor disas with symbol lookup, Fabien Chouteau, 2013/10/04
- [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Fabien Chouteau, 2013/10/04
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Peter Maydell, 2013/10/04
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Andreas Färber, 2013/10/04
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Fabien Chouteau, 2013/10/07
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Peter Maydell, 2013/10/07
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array,
Fabien Chouteau <=
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Peter Maydell, 2013/10/07
- Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array, Fabien Chouteau, 2013/10/07
[Qemu-devel] [PATCH 1/4] Fix coding style, Fabien Chouteau, 2013/10/04