[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH arm-devs v1 06/13] net/cadence_gem: Implement RX
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH arm-devs v1 06/13] net/cadence_gem: Implement RX descriptor match mode flags |
Date: |
Wed, 4 Dec 2013 13:27:22 +1000 |
On Mon, Dec 2, 2013 at 10:19 PM, Peter Maydell <address@hidden> wrote:
> On 2 December 2013 07:12, Peter Crosthwaite
> <address@hidden> wrote:
>> The various Rx packet address matching mode flags were not being set in
>> the rx descriptor. Implement.
>
>> -#define GEM_RX_REJECT 1
>> -#define GEM_RX_ACCEPT 0
>> +#define GEM_RX_REJECT (-1)
>> +#define GEM_RX_PROM_ACCEPT (-2)
>> +#define GEM_RX_BROADCAST_ACCEPT (-3)
>> +#define GEM_RX_MULTICAST_HASH_ACCEPT (-4)
>> +#define GEM_RX_UNICAST_HASH_ACCEPT (-5)
>> +
>> +#define GEM_RX_SAR_ACCEPT 0
>
>> @@ -527,9 +559,6 @@ static unsigned calc_mac_hash(const uint8_t *mac)
>> /*
>> * gem_mac_address_filter:
>> * Accept or reject this destination address?
>> - * Returns:
>> - * GEM_RX_REJECT: reject
>> - * GEM_RX_ACCEPT: accept
>> */
>
> It would be nice to update this comment about the return value rather
> than just deleting it. I think the new semantics are
> "Returns a GEM_RX_ constant, or a valid SAR", right
> (though I may have mangled the SAR terminology, feel free to
> correct/expand).
>
Done.
> thanks
> -- PMM
>
- Re: [Qemu-devel] [PATCH arm-devs v1 03/13] net/cadence_gem: Don't assert against 0 buffer address, (continued)
- [Qemu-devel] [PATCH arm-devs v1 04/13] net/cadence_gem: simplify rx buf descriptor walking, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 05/13] net/cadence_gem: Prefetch rx descriptors ASAP, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 06/13] net/cadence_gem: Implement RX descriptor match mode flags, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 07/13] net/cadence_gem: Implement SAR match bit in rx desc, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 08/13] net/cadence_gem: Implement SAR (de)activation, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 09/13] net/cadence_gem: Fix rx multi-fragment packets, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 10/13] net/cadence_gem: Fix small packet FCS stripping, Peter Crosthwaite, 2013/12/02