[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st un
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm |
Date: |
Fri, 20 Dec 2013 16:29:22 +0000 |
On 20 December 2013 16:26, Richard Henderson <address@hidden> wrote:
> On 12/20/2013 08:08 AM, Peter Maydell wrote:
>>> In particular, opc = 2 && size = 2 should be unallocated.
>>
>> This is LDRSW (immediate), not unallocated, isn't it?
>>
>> I agree the decode logic isn't laid out the same as the ARM ARM,
>> but I'm pretty sure it's correct.
>
> Oops, typo: opc=3 && size=2. Basically,
>
>
> if opc<1> == '0' then
> // store or zero-extending load
> memop = if opc<0> == '1' then MemOp_LOAD else MemOp_STORE;
> regsize = if size == '11' then 64 else 32;
> signed = FALSE;
> else
> if size == '11' then
> memop = MemOp_PREFETCH;
> if opc<0> == '1' then UnallocatedEncoding();
> else
> // sign-extending load
> memop = MemOp_LOAD;
> if size == '10' && opc<0> == '1' then UnallocatedEncoding();
>
> this one ----^
+ if (size == 3 && opc == 2) {
+ /* PRFM - prefetch */
+ return;
+ }
+ if (opc == 3 && size > 1) {
+ unallocated_encoding(s);
+ return;
+ }
+ is_store = (opc == 0);
+ is_signed = opc & (1<<1);
+ is_extended = (size < 3) && (opc & 1);
That is caught by 'if (opc == 3 && size > 1)'.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns, (continued)
[Qemu-devel] [PATCH 18/21] target-arm: aarch64: add support for ld lit, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 14/21] target-arm: A64: Implement minimal set of EL0-visible sysregs, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Peter Maydell, 2013/12/17
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Richard Henderson, 2013/12/19
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Peter Maydell, 2013/12/20
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Richard Henderson, 2013/12/20
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Richard Henderson, 2013/12/20
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Peter Maydell, 2013/12/20
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Richard Henderson, 2013/12/20
- Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Peter Maydell, 2013/12/20
[Qemu-devel] [PATCH 10/21] target-arm: A64: implement FMOV, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 19/21] target-arm: Widen exclusive-access support struct fields to 64 bits, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 21/21] default-configs: Add config for aarch64-linux-user, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 04/21] target-arm: A64: add support for ld/st with index, Peter Maydell, 2013/12/17