[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking m
From: |
Cole Robinson |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode |
Date: |
Wed, 02 Apr 2014 09:26:01 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/02/2014 08:32 AM, Takashi Iwai wrote:
> The relative pointer tracking mode was still buggy even after the
> previous fix of the motion-notify-event since the events are filtered
> out when the pointer moves outside the drawing window due to the
> boundary check for the absolute mode.
>
> This patch fixes the issue by moving the unnecessary boundary check
> into the if block of absolute mode, and keep the coordinate in the
> relative mode even if it's outside the drawing area. But this makes
> the coordinate (last_x, last_y) possibly pointing to (-1,-1),
> introduce a new flag to indicate the last coordinate has been
> updated.
>
> Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587
> Signed-off-by: Takashi Iwai <address@hidden>
Tested-by: Cole Robinson <address@hidden>
Reviewed-by: Cole Robinson <address@hidden>
Thanks,
Cole
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, (continued)
[Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event, Takashi Iwai, 2014/04/02
[Qemu-devel] [PATCH v2 3/4] gtk: Remember the last grabbed pointer position, Takashi Iwai, 2014/04/02
[Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode, Takashi Iwai, 2014/04/02
- Re: [Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode,
Cole Robinson <=