[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instea
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event |
Date: |
Wed, 02 Apr 2014 17:17:54 +0200 |
On Mi, 2014-04-02 at 14:32 +0200, Takashi Iwai wrote:
> +static gboolean gd_event(GtkWidget *widget, GdkEvent *event, void
> *opaque)
> +{
> + if (event->type == GDK_MOTION_NOTIFY)
> + return gd_motion_event(widget, &event->motion, opaque);
> + return FALSE;
> +}
Fails checkpatch:
WARNING: braces {} are necessary for all arms of this statement
#12: FILE: ui/gtk.c:771:
+ if (event->type == GDK_MOTION_NOTIFY)
[...]
total: 0 errors, 1 warnings, 23 lines checked
cheers,
Gerd
- Re: [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option, (continued)
- Re: [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option, Gerd Hoffmann, 2014/04/02
- [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Cole Robinson, 2014/04/02
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Gerd Hoffmann, 2014/04/02
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Takashi Iwai, 2014/04/02
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Cole Robinson, 2014/04/02
- Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode, Takashi Iwai, 2014/04/03
[Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event, Takashi Iwai, 2014/04/02
[Qemu-devel] [PATCH v2 3/4] gtk: Remember the last grabbed pointer position, Takashi Iwai, 2014/04/02
[Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode, Takashi Iwai, 2014/04/02