[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V5 07/28] qapi event: convert SHUTDOWN

From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH V5 07/28] qapi event: convert SHUTDOWN
Date: Wed, 07 May 2014 20:55:58 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

于 2014/5/1 22:44, Eric Blake 写道:
On 04/30/2014 10:26 PM, Wenchao Xia wrote:
Signed-off-by: Wenchao Xia <address@hidden>
  vl.c |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

This, and many of the subsequent patches in the series, are a bit
misleading; I have to go back to 5/28 to make sure that both pieces of
the conversion are in sync.  Is there a technical reason why you can't
provide both the qapi definition and the conversion to the new
qapi_event_send_FOO function in the same patch, one patch per FOO,
rather than your current split?

  No, it is just easy to get conflict to modifiy one file in 20+
patches when rebase, so I modified it once in patch 5/28. I'll adjust
it in next version.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]