[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message
Date: Tue, 13 May 2014 19:48:30 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Mike Day <address@hidden> writes:

> The help message for qemu-img lists the supported block formats, of
> which there are 27 as of version 2.0.50. The formats are printed in
> the order of their driver's position in a linked list, which appears
> random. This patch prints the formats in sorted order, making it
> easier to read and to find a specific format in the list.

Patch revision notes like these

> [Added suggestions from Fam Zheng <address@hidden> to declare variables
> at the top of the scope in help() and to omit explicit cast for void*
> opaque.
> --Stefan]
> [Removed call to g_sequence_lookup because it breaks the build on
>  machines with glib < 2.28.
> --Mike]
> Signed-off-by: Mike Day <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---

... go here, below the '---'.

Furthermore, your previous patch went in already.  We need an
incremental patch to get rid of the dependency on non-ancient glib.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]