[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/5] char: Use return values instead of error

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 1/5] char: Use return values instead of error_is_set(errp)
Date: Mon, 19 May 2014 11:14:23 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/19/2014 10:57 AM, Markus Armbruster wrote:
> Using error_is_set(errp) to check whether a function call failed is
> fragile: it breaks when errp is null.  Check perfectly suitable return
> values instead when possible.  As far as I can tell, errp can't be
> null there, but this is more robust and more obviously correct
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qemu-char.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]