[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/5] char: Explain qmp_chardev_add()'s unusua

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 3/5] char: Explain qmp_chardev_add()'s unusual error handling
Date: Mon, 19 May 2014 11:16:06 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/19/2014 10:57 AM, Markus Armbruster wrote:
> Character backend open hasn't been fully converted to the Error API.
> Some opens fail without setting an error.  qmp_chardev_add() needs to
> detect when that happens, and set a generic error.  Explain that in a
> comment, and inline error_is_set() for clarity.
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qemu-char.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]