[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/4] buildsys: Fix module build for block-iscsi.

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 0/4] buildsys: Fix module build for block-iscsi.so
Date: Fri, 23 May 2014 13:36:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 23/05/2014 05:02, Fam Zheng ha scritto:
We get:

    $ qemu-img
    Failed to open module: /home/fam/build/master/block-iscsi.so: undefined 
symbol: bitmap_set
    qemu-img: Not enough arguments
    Try 'qemu-img --help' for more information

Because since commit b03c38 (block/iscsi: speed up read for unallocated
sectors), block/iscsi.c calls utils/bitmap.c:bitmap_* functions, which is not
linked to qemu-img nor shared objects.

This series links module objects to libqemuutil.a. That requires -fPIC on the
static library objects. The first patch unifies the dependency path of
util-obj-y to libqemuutil.a by removing individual object list from
libcacard-obj-y, so we can apply -fPIC from libqemuutils.a's object specific

Also added a travis build task for --enable-modules.


Fam Zheng (4):
  Makefile: Link vscclient with libqemuutil.a and libqemustub.a
  Makefile: Compile libqemustub.a and libqemuutil.a with -fPIC
  rules.mak: Link DSO with libqemuutil.a
  .travis.yml: Add a new build target with --enable-modules

 .travis.yml        | 3 +++
 Makefile           | 1 +
 libcacard/Makefile | 9 ++-------
 rules.mak          | 2 +-
 4 files changed, 7 insertions(+), 8 deletions(-)

Applying patch 4.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]