Re: [Qemu-devel] [Qemu-stable] [PATCH 01/14] qemu-img: Plug memory leak on block option help error path

[Benoît Canet]

The Monday 26 May 2014 à 19:37:02 (+0200), Markus Armbruster wrote :
> Introduced in commit a283cb6; mostly harmless.  Spotted by Coverity.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qemu-img.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 1ad899e..62ea27e 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -287,6 +287,7 @@ static int print_block_option_help(const char *filename, 
> const char *fmt)
>          proto_drv = bdrv_find_protocol(filename, true);
>          if (!proto_drv) {
>              error_report("Unknown protocol '%s'", filename);
> +            free_option_parameters(create_options);
>              return 1;
>          }
>          create_options = append_option_parameters(create_options,
> -- 
> 1.9.3
> 
> 
Reviewed-by: Benoit Canet <address@hidden>