[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open witho
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails |
Date: |
Tue, 27 May 2014 12:41:59 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Monday 26 May 2014 à 19:37:08 (+0200), Markus Armbruster wrote :
> Reproducer: "open -o a=b". Broken in commit fd0fee3.
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qemu-io.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-io.c b/qemu-io.c
> index ffbad25..0daf413 100644
> --- a/qemu-io.c
> +++ b/qemu-io.c
> @@ -61,7 +61,8 @@ static int openfile(char *name, int flags, int growable,
> QDict *opts)
> if (bdrv_open(&qemuio_bs, name, NULL, opts, flags | BDRV_O_PROTOCOL,
> NULL, &local_err))
> {
> - fprintf(stderr, "%s: can't open device %s: %s\n", progname, name,
> + fprintf(stderr, "%s: can't open%s%s: %s\n", progname,
> + name ? " device " : "", name ?: "",
name ?: "" seems to be a GNU C extension: see
http://en.wikipedia.org/wiki/%3F:#C
Don't we want this code to work on most compilers ?
Best regards
Benoît
> error_get_pretty(local_err));
> error_free(local_err);
> return 1;
> @@ -72,7 +73,8 @@ static int openfile(char *name, int flags, int growable,
> QDict *opts)
> if (bdrv_open(&qemuio_bs, name, NULL, opts, flags, NULL, &local_err)
> < 0)
> {
> - fprintf(stderr, "%s: can't open device %s: %s\n", progname, name,
> + fprintf(stderr, "%s: can't open%s%s: %s\n", progname,
> + name ? " device " : "", name ?: "",
> error_get_pretty(local_err));
> error_free(local_err);
> bdrv_unref(qemuio_bs);
> --
> 1.9.3
>
>
- Re: [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), (continued)
- [Qemu-devel] [PATCH 14/14] qemu-img: Plug memory leak in convert command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 10/14] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 01/14] qemu-img: Plug memory leak on block option help error path, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails, Markus Armbruster, 2014/05/26
- Re: [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails,
Benoît Canet <=
- Re: [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails, Kevin Wolf, 2014/05/28
- [Qemu-devel] [PATCH 05/14] qemu-io: Support multiple -o in open command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 09/14] blockdev: Plug memory leak in drive_init(), Markus Armbruster, 2014/05/26