[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/9] block: Move bdrv_fill_options() call to
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/9] block: Move bdrv_fill_options() call to bdrv_open() |
Date: |
Wed, 25 Jun 2014 09:40:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/25/2014 08:35 AM, Kevin Wolf wrote:
> bs->options now contains the modified version of the options.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 25 +++++++++++++++----------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/block.c b/block.c
> index f1c3b57..b1087e6 100644
> --- a/block.c
> +++ b/block.c
> @@ -1009,14 +1009,19 @@ free_and_fail:
> * Fills in default options for opening images and converts the legacy
> * filename/flags pair to option QDict entries.
> */
> -static int bdrv_fill_options(QDict **options, const char *filename,
> +static int bdrv_fill_options(QDict **options, const char *filename, int
> flags,
> Error **errp)
Yep, that cleans up my comment in 1/9.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1, Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 2/9] block: Move bdrv_fill_options() call to bdrv_open(), Kevin Wolf, 2014/06/25
- Re: [Qemu-devel] [PATCH v2 2/9] block: Move bdrv_fill_options() call to bdrv_open(),
Eric Blake <=
- [Qemu-devel] [PATCH v2 1/9] block: Create bdrv_fill_options(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 5/9] block: Use common driver selection code for bdrv_open_file(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 3/9] block: Move json: parsing to bdrv_fill_options(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 4/9] block: Always pass driver name through options QDict, Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 6/9] block: Inline bdrv_file_open(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 7/9] block: Remove second bdrv_open() recursion, Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to non-COW drivers, Kevin Wolf, 2014/06/25