[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/8] BitmapLog: cancel mechanism for an alrea
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 5/8] BitmapLog: cancel mechanism for an already running dump bitmap process |
Date: |
Fri, 18 Jul 2014 06:22:58 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote:
> Signed-off-by: Sanidhya Kashyap <address@hidden>
> ---
> hmp-commands.hx | 14 ++++++++++++++
> hmp.c | 5 +++++
> hmp.h | 1 +
> qapi-schema.json | 8 ++++++++
> qmp-commands.hx | 21 +++++++++++++++++++++
> savevm.c | 19 +++++++++++++++++++
> 6 files changed, 68 insertions(+)
So here you provide HMP and QMP in one patch (fine); but earlier you
separated them between 3/8 and 4/8. Might be nice to be consistent in
the series.
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 575df78..61eca66 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1804,6 +1804,20 @@ STEXI
> dumps the writable working set of a VM's memory to a file
> ETEXI
>
> + {
> + .name = "ldbc|log-dirty-bitmap-cancel",
HMP commands still use _ in their names; it's only QMP where we prefer dash.
> +++ b/qapi-schema.json
> @@ -3503,3 +3503,11 @@
> 'data' : { 'filename' : 'str',
> '*epochs' : 'int',
> '*frequency' : 'int' } }
> +##
> +# @log-dirty-bitmap-cancel
> +#
> +# cancel the dirty bitmap logging process
> +#
> +# Since 2.2
> +##
> +{ 'command': 'log-dirty-bitmap-cancel' }
Correctly named with dash here...
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 200f57e..69d4a07 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -3785,3 +3785,24 @@ Examples:
> Note: The epochs, frequency and readable are optional. epochs default
> value is 3 while that of frequency is 10.
> EQMP
> +
> + {
> + .name = "log-dirty-bitmap-cancel",
> + .args_type = "",
> + .mhandler.cmd_new = qmp_marshal_input_log_dirty_bitmap_cancel,
> + },
> +
> +SQMP
> +log_bitmap_cancel
...but completely wrong name here.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v4 2/8] RunState: added two new flags for bitmap dump and migration process, (continued)
- [Qemu-devel] [PATCH v4 3/8] BitmapLog: bitmap dump code via QAPI framework with runstates, Sanidhya Kashyap, 2014/07/17
- [Qemu-devel] [PATCH v4 4/8] BitmapLog: hmp interface for dirty bitmap dump, Sanidhya Kashyap, 2014/07/17
- [Qemu-devel] [PATCH v4 5/8] BitmapLog: cancel mechanism for an already running dump bitmap process, Sanidhya Kashyap, 2014/07/17
- Re: [Qemu-devel] [PATCH v4 5/8] BitmapLog: cancel mechanism for an already running dump bitmap process,
Eric Blake <=
- [Qemu-devel] [PATCH v4 6/8] BitmapLog: set the frequency of the dump bitmap process, Sanidhya Kashyap, 2014/07/17
- [Qemu-devel] [PATCH v4 7/8] BitmapLog: get the information about the parameters, Sanidhya Kashyap, 2014/07/17
- [Qemu-devel] [PATCH v4 8/8] BitmapLog: python script for extracting bitmap from a binary file, Sanidhya Kashyap, 2014/07/17
- Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging, Dr. David Alan Gilbert, 2014/07/18