[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present |
Date: |
Thu, 20 Nov 2014 12:29:57 +0000 |
On 20 November 2014 12:05, Liviu Ionescu <address@hidden> wrote:
> For standalone emulation, the image must be specified via -kernel,
> but when using QEMU as a GDB server, the presence of -kernel is
> no longer mandatory, since the image can be loaded by the GDB client.
I think the correct fix for this issue is:
> - if (!kernel_filename && !qtest_enabled()) {
> + if (!kernel_filename && !qtest_enabled() && !with_gdb) {
> fprintf(stderr, "Guest image must be specified (using -kernel)\n");
> exit(1);
> }
just delete this entire if() statement. This is how we've handled
similar issues with the ARM A profile boards. (Some of the boards
still have those checks but that's just because nobody's bothered
to fix them yet.)
thanks
-- PMM