[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence
Date: Mon, 02 Feb 2015 14:18:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 02/02/2015 13:42, Pavel Dovgaluk wrote:
>> From: Paolo Bonzini [mailto:address@hidden
>> On 02/02/2015 13:28, Pavel Dovgaluk wrote:
>>>>>>>                              cpu->exception_index = EXCP_INTERRUPT;
>>>>>>>                              next_tb = 0;
>>>>>>> +                            qemu_notify_event();
>>>>> Why is this needed?
>>> It is needed to wake up iothread in replay mode.
>>> Otherwise it waits for additional time and replay becomes too slow.
>> What event (something from a timerlist?) is ready, that has not been
>> notified to the iothread yet?  qemu_notify_event() should never be
>> needed in common case.  It's probably missing somewhere else.
> I think in this case there are no events at all - just reading timers values
> that were made while recording.
> We have to replay these reads by waking iothread.

I think the right place for this is in replay_read_next_clock then.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]