Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

[Chen, Tiejun]

On 2015/2/10 3:56, Michael S. Tsirkin wrote:
> It doesn't make sense to copy values manually:
> the only issue with getting headers from linux
> seems to be dealing with linux/types, we
> can easily fix that automatically while importing.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>
> FYI this is what I propose instead of the recently
> suggested
>      virtio: uniform virtio device IDs
> we can then rework existing code to include these headers.
>
> Will automatically bring in goodies as they arrive in linux.
>
> This doesn't yet import virtio ccw header,
> that won't be hard to add later.
>
>   scripts/update-linux-headers.sh | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index c8e026d..0bd8437 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -76,4 +76,14 @@ else
>       cp "$linux/COPYING" "$output/linux-headers"
>   fi
>
> +rm -rf "$output/standard-headers/linux"
> +mkdir -p "$output/standard-headers/linux"

Shouldn't we add something in configure file to execute this automatically?

Or instead of creating 'standard-headers/, why can't we go that existing 
linux-headers/?

Thanks
Tiejun

> +for f in $tmpdir/include/linux/virtio*h; do
> +    header=$(expr "$f" : '.*/\(.*\)');
> +    sed -e 's/__u\([0-9][0-9]*\)/uint\1_t/g' \
> +        -e 's/linux\/types/inttypes/' \
> +        -e 's/__bitwise__//' \
> +        "$tmpdir/include/linux/$header" > \
> +        "$output/standard-headers/linux/$header";
> +done
>   rm -rf "$tmpdir"