[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virti

From: Chen, Tiejun
Subject: Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs
Date: Wed, 11 Feb 2015 16:08:54 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2015/2/11 11:46, Peter Maydell wrote:
On 11 February 2015 at 02:50, Chen, Tiejun <address@hidden> wrote:
On 2015/2/11 10:03, Peter Maydell wrote:
The linux-headers/ directory contains header files which can only
validly be included if the host we're compiling on is Linux. Some
of them will cause compile failures on OSX or Windows if they
are in the include path. The idea of this patch is that the
standard-headers/ directory has "sanitized" header files which
have had the linux-specific types and includes stripped out.
So if we take the route this patch proposes we do need two

This confounds me since for instance, one of goals based on this patch is,
it exposes those Virtio devices ID definition to hw/virtio, instead of my
original patch, right? So without this sort of standard-hearders, how can we
compile virtio? Or you mean we still keep those original stuff in
include/hw/virtio*, but somehow update them once we execute that script

I'm confused about why you're confused. We have two basic
approaches we can take:

(1) What we do at the moment. There are headers defining the virtio
interface in include/hw/virtio, and these are basically manually
created and updated as necessary.

(2) What this patch is proposing. The headers defining virtio are
automatically copied into standard-headers/ and fixed up to make
them work with QEMU on all the hosts we support. This happens when
this script is run by a developer to update QEMU's headers based
on some new upstream kernel.

I guess this mean this patch should be extended to smooth something in include/hw/virtio* in some ways.

Personally I think that option 1 is more reliable and overall


less effort, since automatiing the fixups is hard and virtio
doesn't change very much.

So sounds my original patch is fine to you.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]