[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __li

From: Chen Gang S
Subject: Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully
Date: Wed, 25 Feb 2015 09:01:56 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2/25/15 02:18, Chris Metcalf wrote:
> On 2/24/2015 12:25 PM, Chen Gang S wrote:
>> For me, if the raw integer is only used once, we needn't define a macro
>> for it (instead of, we can give a comment for it).
> The advantage of names even in this case is that you can group all the
> macro definitions in one place where they are easy to read and review.
> Then later when you use them they are self-documenting.

Yeah, what you said sounds reasonable to me.

At present (and originally), I was not quit sure each number's meaning,
so I left them as raw number, now. After I have enough more numbers, I
shall consider of their meanings, together, then use macros in one area.

>                                                         And if you
> are going to use opcode_tilegx.h anyway, you get the names "for free".

OK, thanks. I shall use opcode_tilegx.h, and we needn't consider about
these raw numbers.

That is also one of reason why I am not consider more for these numbers:
since the code is before reviewing, if not quite necessary, I will not
devote more time resources on coding styles. ;-)

Chen Gang

Open, share, and attitude like air, water, and life which God blessed

reply via email to

[Prev in Thread] Current Thread [Next in Thread]