[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with

From: Chen Gang S
Subject: Re: [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features
Date: Sun, 01 Mar 2015 04:04:08 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 2/28/15 13:20, Chen Gang S wrote:
>>> diff --git a/target-tilegx/helper.h b/target-tilegx/helper.h
>>> >> new file mode 100644
>>> >> index 0000000..e69de29
>> > 
>> > Is this empty file actually included from somewhere in this patch?
>> > 
> Yes, it is for future use, I guess, at present, we can just drop it:
>  - "translate.c" includes "exec/helper-gen.h".
>  - "exec/helper-gen.h" includes "helper.h".

Oh, sorry, I forgot, "tcg/tcg-op.h" -> "helper-proto.h" -> "helper.h"

    CC    tilegx-linux-user/tcg/tcg.o
  In file included from /upstream/qemu/tcg/tcg-op.h:26:0,
                   from /upstream/qemu/tcg/tcg.c:49:
  /upstream/qemu/include/exec/helper-proto.h:29:20: fatal error: helper.h: No 
such file or directory
   #include "helper.h"

So for me, we have to still use an empty "helper.h" file for it.

Chen Gang

Open, share, and attitude like air, water, and life which God blessed

reply via email to

[Prev in Thread] Current Thread [Next in Thread]