[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 28/40] qapi: Prefer 'struct' over 'type' in g

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v8 28/40] qapi: Prefer 'struct' over 'type' in generator
Date: Mon, 04 May 2015 19:46:55 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Eric Blake <address@hidden> writes:

> Referring to "type" as both a meta-type (built-in, enum, union,
> alternate, or struct) and a specific type (the name that the
> schema uses for declaring structs) is confusing.  The confusion
> is only made worse by the fact that the generator mostly already
> refers to struct even when dealing with expr['type'].  This
> commit changes the generator to consistently refer to it as
> struct everywhere, plus a single back-compat tweak that allows
> accepting the existing .json files as-is, so that the meat of
> this change is separate from the mindless churn of that change.
> Fix the testsuite fallout for error messages that change, and
> in some cases, become more legible.  Improve comments to better
> match our intentions where a struct (rather than any complex
> type) is required.  Note that in some cases, an error message
> now refers to 'struct' while the schema still refers to 'type';
> that will be cleaned up in the later commit to the schema.
> Signed-off-by: Eric Blake <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]