[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when re
Daniel P. Berrange
Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required
Wed, 13 May 2015 09:09:06 +0100
On Tue, May 12, 2015 at 12:32:53PM -0600, Eric Blake wrote:
> On 05/12/2015 10:09 AM, Daniel P. Berrange wrote:
> > The qemu-io tool does not check if the image is encrypted so
> > historically would silently corrupt the sectors by writing
> > plain text data into them instead of cipher text. The earlier
> > commit turns this mistake into a fatal abort, so check for
> > encryption and prompt for key when required.
> Doesn't that mean that 'git bisect' gives a crashing qemu-io for 3
> patches? Should this be rearranged so that 1/5 comes after this to
> avoid triggering the abort?
I'm ambivalent on that - previously qemu-io was data corrupting
for this scenario, so crashing isn't really that much worse :-)
It is easy enough to reorder these though if that's desired.
The latter patches have no build time dep on the 1st patch, so
its trivial for Kevin to re-order when applying if he thinks it
is worth it.
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
[Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required, Daniel P. Berrange, 2015/05/12
[Qemu-devel] [PATCH 2/5] util: move read_password method out of qemu-img into osdep/oslib, Daniel P. Berrange, 2015/05/12
Re: [Qemu-devel] [PATCH 0/5] Misc fixes and testing of qcow encryption, Kevin Wolf, 2015/05/18
- Re: [Qemu-devel] [PATCH 1/5] qcow2/qcow: protect against uninitialized encryption key, (continued)