[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when re

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required
Date: Wed, 13 May 2015 12:50:38 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

"Daniel P. Berrange" <address@hidden> writes:

> On Tue, May 12, 2015 at 12:32:53PM -0600, Eric Blake wrote:
>> On 05/12/2015 10:09 AM, Daniel P. Berrange wrote:
>> > The qemu-io tool does not check if the image is encrypted so
>> > historically would silently corrupt the sectors by writing
>> > plain text data into them instead of cipher text. The earlier
>> > commit turns this mistake into a fatal abort, so check for
>> > encryption and prompt for key when required.
>> Doesn't that mean that 'git bisect' gives a crashing qemu-io for 3
>> patches?  Should this be rearranged so that 1/5 comes after this to
>> avoid triggering the abort?
> I'm ambivalent on that - previously qemu-io was data corrupting
> for this scenario, so crashing isn't really that much worse :-)

If it crashes before it can corrupt anything, I'd sell it as an
improvement ;)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]