[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/15] tap: Improve -netdev/netdev_add/-net/...
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 06/15] tap: Improve -netdev/netdev_add/-net/... bridge error reporting |
Date: |
Thu, 14 May 2015 10:56:22 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/12/2015 06:02 AM, Markus Armbruster wrote:
> When -netdev bridge fails, it first reports a specific error, then a
> generic one, like this:
>
> $ qemu-system-x86_64 -netdev bridge,id=foo
> failed to launch bridge helper
> qemu-system-x86_64: -netdev bridge,id=foo: Device 'bridge' could not be
> initialized
>
> The first message goes to stderr. Wrong for HMP, because errors need
> to go to the monitor there.
>
> The second message goes to stderr for -netdev, to the monitor for HMP
> netdev_add, and becomes the error reply for QMP netdev_add.
>
> Convert net_bridge_run_helper() to Error, and propagate its errors
> through net_init_bridge(). This ensures the error gets reported where
> the user is, and suppresses the unwanted second message.
>
> While there, improve the error messages a bit.
>
> The above example becomes:
>
> $ qemu-system-x86_64 -netdev bridge,id=foo
> qemu-system-x86_64: -netdev bridge,id=foo: bridge helper failed
>
> net_init_tap() also uses net_bridge_run_helper(). Propagate its
> errors there as well. Improves reporting these errors with -netdev
> tap & friends.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> net/tap.c | 30 +++++++++++++++++++-----------
> 1 file changed, 19 insertions(+), 11 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 04/15] net/dump: Improve -net/host_net_add dump error reporting, (continued)
- [Qemu-devel] [PATCH 03/15] net: Improve -net nic error reporting, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 07/15] tap: Convert tap_set_sndbuf() to Error, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 06/15] tap: Improve -netdev/netdev_add/-net/... bridge error reporting, Markus Armbruster, 2015/05/12
- Re: [Qemu-devel] [PATCH 06/15] tap: Improve -netdev/netdev_add/-net/... bridge error reporting,
Eric Blake <=
- [Qemu-devel] [PATCH 11/15] tap-linux: Convert tap_open() to Error, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 10/15] tap: Permit incremental conversion of tap_open() to Error, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 12/15] tap-bsd: Convert tap_open() to Error, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 01/15] net: Improve error message for -net hubport a bit, Markus Armbruster, 2015/05/12
- [Qemu-devel] [PATCH 09/15] tap: Convert launch_script() to Error, Markus Armbruster, 2015/05/12