[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v1 2/3] target-microblaze: Allow the stack protect
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [RFC v1 2/3] target-microblaze: Allow the stack protection to be disabled |
Date: |
Fri, 15 May 2015 08:53:12 +1000 |
On Fri, May 15, 2015 at 4:36 AM, Richard Henderson <address@hidden> wrote:
> On 05/13/2015 11:08 PM, Alistair Francis wrote:
>> void helper_stackprot(CPUMBState *env, uint32_t addr)
>> {
>> - if (addr < env->slr || addr > env->shr) {
>> + MicroBlazeCPU *cpu = mb_env_get_cpu(env);
>> +
>> + if (cpu->cfg.stackproc && (addr < env->slr || addr > env->shr)) {
>
> This check should be done in translate.c to avoid calling this function in the
> first place.
Looking at it again I agree, I will move it.
Thanks,
Alistair
>
>
> r~
>
- [Qemu-devel] [RFC v1 0/3] Add Microblaze configuration options, Alistair Francis, 2015/05/14
- [Qemu-devel] [RFC v1 1/3] target-microblaze: Fix up indentation, Alistair Francis, 2015/05/14
- [Qemu-devel] [RFC v1 2/3] target-microblaze: Allow the stack protection to be disabled, Alistair Francis, 2015/05/14
- [Qemu-devel] [RFC v1 3/3] target-microblaze: Convert use-fpu to a CPU property, Alistair Francis, 2015/05/14
- Re: [Qemu-devel] [RFC v1 3/3] target-microblaze: Convert use-fpu to a CPU property, Peter Crosthwaite, 2015/05/15
- Re: [Qemu-devel] [RFC v1 3/3] target-microblaze: Convert use-fpu to a CPU property, Alistair Francis, 2015/05/15
- Re: [Qemu-devel] [RFC v1 3/3] target-microblaze: Convert use-fpu to a CPU property, Peter Crosthwaite, 2015/05/15
- Re: [Qemu-devel] [RFC v1 3/3] target-microblaze: Convert use-fpu to a CPU property, Alistair Francis, 2015/05/15
- Re: [Qemu-devel] [RFC v1 3/3] target-microblaze: Convert use-fpu to a CPU property, Peter Crosthwaite, 2015/05/15
- Re: [Qemu-devel] [RFC v1 3/3] target-microblaze: Convert use-fpu to a CPU property, Alistair Francis, 2015/05/15
- Re: [Qemu-devel] [RFC v1 3/3] target-microblaze: Convert use-fpu to a CPU property, Peter Crosthwaite, 2015/05/15