[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/11] qemu-iotests: fix test_stream_partial()
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 07/11] qemu-iotests: fix test_stream_partial() |
Date: |
Fri, 15 May 2015 10:43:40 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, 05/13 16:27, Alberto Garcia wrote:
> This test is streaming to the top layer using the intermediate image
> as the base. This is a mistake since block-stream never copies data
> from the base image and its backing chain, so this is effectively a
> no-op.
>
> In addition to fixing the base parameter, this patch also writes some
> data to the intermediate image before the test, so there's something
> to copy and the test is meaningful.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
> ---
> tests/qemu-iotests/030 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
> index 7ca9b25..6e6cb5a 100755
> --- a/tests/qemu-iotests/030
> +++ b/tests/qemu-iotests/030
> @@ -35,6 +35,7 @@ class TestSingleDrive(iotests.QMPTestCase):
> qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' %
> backing_img, mid_img)
> qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' %
> mid_img, test_img)
> qemu_io('-f', 'raw', '-c', 'write -P 0x1 0 512', backing_img)
> + qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0x1 524288 512',
> mid_img)
> self.vm = iotests.VM().add_drive("blkdebug::" + test_img)
> self.vm.launch()
>
> @@ -93,7 +94,7 @@ class TestSingleDrive(iotests.QMPTestCase):
> def test_stream_partial(self):
> self.assert_no_active_block_jobs()
>
> - result = self.vm.qmp('block-stream', device='drive0', base=mid_img)
> + result = self.vm.qmp('block-stream', device='drive0',
> base=backing_img)
> self.assert_qmp(result, 'return', {})
>
> self.wait_until_completed()
> --
> 2.1.4
>
>
- [Qemu-devel] [PATCH v7 00/11] Support streaming to an intermediate layer, Alberto Garcia, 2015/05/13
- [Qemu-devel] [PATCH 09/11] qemu-iotests: test streaming to an intermediate layer, Alberto Garcia, 2015/05/13
- [Qemu-devel] [PATCH 08/11] qemu-iotests: add no-op streaming test, Alberto Garcia, 2015/05/13
- [Qemu-devel] [PATCH 01/11] block: keep a list of block jobs, Alberto Garcia, 2015/05/13
- [Qemu-devel] [PATCH 05/11] block: Add QMP support for streaming to an intermediate layer, Alberto Garcia, 2015/05/13
- [Qemu-devel] [PATCH 07/11] qemu-iotests: fix test_stream_partial(), Alberto Garcia, 2015/05/13
- Re: [Qemu-devel] [PATCH 07/11] qemu-iotests: fix test_stream_partial(),
Fam Zheng <=
- [Qemu-devel] [PATCH 04/11] block: Support streaming to an intermediate layer, Alberto Garcia, 2015/05/13
- [Qemu-devel] [PATCH 06/11] docs: Document how to stream to an intermediate layer, Alberto Garcia, 2015/05/13
- [Qemu-devel] [PATCH 11/11] qemu-iotests: test overlapping block-stream operations, Alberto Garcia, 2015/05/13