[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 29/34] qemu-iotests: Remove cache mode test with

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 29/34] qemu-iotests: Remove cache mode test without medium
Date: Fri, 15 May 2015 19:53:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 08.05.2015 19:22, Kevin Wolf wrote:
Specifying the cache mode for a driver without a medium is not a useful
thing to do: As long as there is no medium, the cache mode doesn't make
a difference, and once the 'change' command is used to insert a medium,
it ignores the old cache mode and makes the new medium use

Later patches will make it an error to specify the cache mode for an
empty drive. Remove the corresponding test case.

Signed-off-by: Kevin Wolf <address@hidden>
  tests/qemu-iotests/051     | 14 --------------
  tests/qemu-iotests/051.out | 26 --------------------------
  2 files changed, 40 deletions(-)

Well, you could have changed it to format=null-co or something...

But it's your test so it's your call whether to remove it or not.

Reviewed-by: Max Reitz <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]