[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 30/34] block: reopen: Extract QemuOpts for gener

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 30/34] block: reopen: Extract QemuOpts for generic block layer options
Date: Fri, 15 May 2015 20:07:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 08.05.2015 19:22, Kevin Wolf wrote:
This patch adds a QemuOpts for generic block layer options to
bdrv_reopen_prepare(). The only two options that exist currently
(node-name and driver) cannot be changed

And I don't suppose we want them to be changed at some point.

(changing node-name doesn't really make sense, because it's not really meant for human usage anyway, and tools don't need to change it once it's set, they just need a unique name; and I can't think of a useful use case for changing the driver)

, so the only thing we do is
putting them right back into the QDict so that we check at the end that
they are indeed unchanged.

We will add new options soon that can actually be changed.

Signed-off-by: Kevin Wolf <address@hidden>
  block.c | 24 ++++++++++++++++++++++++
  1 file changed, 24 insertions(+)

Reviewed-by: Max Reitz <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]