[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qemu v7 06/14] spapr_iommu: Introduce "enabled"

From: Alexey Kardashevskiy
Subject: Re: [Qemu-devel] [PATCH qemu v7 06/14] spapr_iommu: Introduce "enabled" state for TCE table
Date: Wed, 27 May 2015 01:49:38 +1000
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 05/27/2015 12:58 AM, Paolo Bonzini wrote:

On 26/05/2015 16:55, Michael Roth wrote:
That's not a problem, there's memory_region_set_size for that.

What on earth, I could've sworn I looked for this... yes I think that
would solve the issue here. mr_add/mr_del can handle the change in
offsets, set size can deal with the change and size, and we can then
move to using an MR allocated at IOMMU creation time.

It's very little used, but that's just because it's not too common.
There's nothing wrong with it. :)

If you do del/set_size/add, you may want to put a
memory_region_transaction_{begin,commit} around the whole dance.

Here I lost you again :)
Why? These are IOMMU MRs -> they are dynamic, what will begin()/commit() change here?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]