[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qemu v7 06/14] spapr_iommu: Introduce "enabled"

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH qemu v7 06/14] spapr_iommu: Introduce "enabled" state for TCE table
Date: Tue, 26 May 2015 17:51:19 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 26/05/2015 17:49, Alexey Kardashevskiy wrote:
>> It's very little used, but that's just because it's not too common.
>> There's nothing wrong with it. :)
>> If you do del/set_size/add, you may want to put a
>> memory_region_transaction_{begin,commit} around the whole dance.
> Here I lost you again :)
> Why? These are IOMMU MRs -> they are dynamic, what will begin()/commit()
> change here?

If you don't add them, the memory core may create two or three different
flatviews.  With begin/commit, it will only do one change.  It's just an


reply via email to

[Prev in Thread] Current Thread [Next in Thread]