[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data va
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values. |
Date: |
Tue, 15 Sep 2015 11:07:02 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
CC Konrad
On Mon, 14 Sep 2015, Paolo Bonzini wrote:
> On 10/09/2015 19:15, Stefano Stabellini wrote:
> > +
> > + switch (reg->size) {
> > + case 1: rc = xen_host_pci_get_byte(&s->real_device, offset,
> > (uint8_t *)&val);
>
> A bit ugly, and it relies on the host being little endian.
>
> > + break;
> > + case 2: rc = xen_host_pci_get_word(&s->real_device, offset,
> > (uint16_t *)&val);
>
> Same here.
cpu_to_le32?
But in practice, Xen being little endian only, I doubt that xen_pt_config_init.c
would actually work on be.
> > + break;
> > + case 4: rc = xen_host_pci_get_long(&s->real_device, offset, &val);
> > + break;
> > + default: assert(1);
>
> This should be assert(0) or, better, abort().
- [Qemu-devel] [PULL 09/29] xen, gfx passthrough: register a isa bridge, (continued)
- [Qemu-devel] [PULL 09/29] xen, gfx passthrough: register a isa bridge, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 06/29] xen, gfx passthrough: basic graphics passthrough support, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 08/29] igd gfx passthrough: create a isa bridge, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 26/29] xen/pt: Make xen_pt_unregister_device idempotent, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 13/29] xen/HVM: atomically access pointers in bufioreq handling, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 12/29] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 22/29] xen/pt: Check if reg->init function sets the 'data' past the reg->size, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 28/29] xen/pt: Check for return values for xen_host_pci_[get|set] in init, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values., Stefano Stabellini, 2015/09/10
[Qemu-devel] [PULL 14/29] xen/pt: Update comments with proper function name., Stefano Stabellini, 2015/09/10
[Qemu-devel] [PULL 25/29] xen/pt: Log xen_host_pci_get/set errors in MSI code., Stefano Stabellini, 2015/09/10
[Qemu-devel] [PULL 24/29] xen/pt: Log xen_host_pci_get in two init functions, Stefano Stabellini, 2015/09/10
[Qemu-devel] [PULL 18/29] xen/pt/msi: Add the register value when printing logging and error messages, Stefano Stabellini, 2015/09/10
[Qemu-devel] [PULL 23/29] xen/pt: Remove XenPTReg->data field., Stefano Stabellini, 2015/09/10
[Qemu-devel] [PULL 11/29] xen, gfx passthrough: add opregion mapping, Stefano Stabellini, 2015/09/10