[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 17/46] ivshmem: improve debug messages
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v3 17/46] ivshmem: improve debug messages |
Date: |
Wed, 23 Sep 2015 12:29:10 +0200 |
On Tue, Sep 22, 2015 at 4:23 PM, Claudio Fontana
<address@hidden> wrote:
> This MSI-X use vs not use is a bit confusing to me.
> I see that the use of MSI is controlled mainly by IVSHMEM_MSI (Property
> "msi"),
> but then there are if (msix_present()) checks spread around.
>
> Could this printf be a bit more clear, possibly adding other DPRINTFs as
> necessary?
>
> Is your IVSHMEM_DPRINTF("use msix\n"); actually intended to mean ("using
> MSIX\n")? But then why is the check for if (!msix_present(d)) only afterwards?
I don't remember precisely why it's there, only I probably wanted to
trace the entering of function ivshmem_use_msix().
Let's change it for IVSHMEM_DPRINTF("use msix, present: %d\n",
msix_present(d)); ok?
--
Marc-André Lureau
- [Qemu-devel] [PATCH v3 15/46] ivshmem: initialize max_peer to -1, (continued)
[Qemu-devel] [PATCH v3 20/46] ivshmem: simplify a bit the code, marcandre . lureau, 2015/09/15
[Qemu-devel] [PATCH v3 19/46] ivshmem: print error on invalid peer id, marcandre . lureau, 2015/09/15
[Qemu-devel] [PATCH v3 21/46] ivshmem: use common return, marcandre . lureau, 2015/09/15