|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v1 16/16] io: add QIOChannelBuffer class |
Date: | Fri, 25 Sep 2015 12:15:46 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 18/09/2015 15:19, Daniel P. Berrange wrote: > + if (fds || nfds) { > + error_setg_errno(errp, EINVAL, > + "Channel does not support buffer descriptor > passing"); > + return -1; > + } Typo (file descriptor passing) and the check could be hoisted to io/channel.c by using features. In fact capabilities could perhaps be stored statically in struct QIOChannel as a bitmap? Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |