[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 16/16] io: add QIOChannelBuffer class
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v1 16/16] io: add QIOChannelBuffer class |
Date: |
Fri, 25 Sep 2015 11:21:44 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Sep 25, 2015 at 12:15:46PM +0200, Paolo Bonzini wrote:
>
>
> On 18/09/2015 15:19, Daniel P. Berrange wrote:
> > + if (fds || nfds) {
> > + error_setg_errno(errp, EINVAL,
> > + "Channel does not support buffer descriptor
> > passing");
> > + return -1;
> > + }
>
> Typo (file descriptor passing) and the check could be hoisted to
> io/channel.c by using features.
>
> In fact capabilities could perhaps be stored statically in struct
> QIOChannel as a bitmap?
In general capabilities are static per class, but the socket code is an
exception, because whether you can do FD passing is a runtime check
based on the type of socket you opened. I might still be able to hoist
that up into the base class though, so will investigate..
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
[Qemu-devel] [PATCH v1 10/16] io: add QIOTask class for async operations, Daniel P. Berrange, 2015/09/18
[Qemu-devel] [PATCH v1 16/16] io: add QIOChannelBuffer class, Daniel P. Berrange, 2015/09/18
[Qemu-devel] [PATCH v1 08/16] io: add helper module for creating watches on FDs, Daniel P. Berrange, 2015/09/18
[Qemu-devel] [PATCH v1 11/16] io: add QIOChannelSocket class, Daniel P. Berrange, 2015/09/18
[Qemu-devel] [PATCH v1 04/16] ui: convert VNC startup code to use SocketAddress, Daniel P. Berrange, 2015/09/18
[Qemu-devel] [PATCH v1 06/16] coroutine: move into libqemuutil.a library, Daniel P. Berrange, 2015/09/18
[Qemu-devel] [PATCH v1 09/16] io: pull Buffer code out of VNC module, Daniel P. Berrange, 2015/09/18