[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/36] monitor: use qapi for qmp_capabilities co
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 04/36] monitor: use qapi for qmp_capabilities command |
Date: |
Fri, 25 Sep 2015 09:09:29 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/25/2015 08:03 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> This was initially done to add qmp_capabilities documentation to the
> schema. Then I figured it would also help to get rid of the "middle
> mode" monitor dispatch code.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> monitor.c | 4 ++--
> qapi-schema.json | 17 +++++++++++++++++
> qmp-commands.hx | 2 +-
> 3 files changed, 20 insertions(+), 3 deletions(-)
>
> +++ b/qapi-schema.json
> @@ -21,6 +21,23 @@
> { 'include': 'qapi/introspect.json' }
>
> ##
> +# @qmp_capabilities:
> +#
> +# Enable QMP capabilities.
> +#
> +# Arguments: None.
> +#
> +# Example:
> +#
> +# -> { "execute": "qmp_capabilities" }
> +# <- { "return": {} }
> +#
> +# Notes: This command must be issued before issuing any other command.
I'd also mention that it is only accepted once; maybe this is better?
Notes: This command is valid exactly when first connecting: it must be
issued before any other command will be accepted, and will fail once the
monitor is accepting other commands.
Otherwise, I'm a fan of this patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 02/36] qapi: add missing @, (continued)
- [Qemu-devel] [PATCH 04/36] monitor: use qapi for qmp_capabilities command, marcandre . lureau, 2015/09/25
- Re: [Qemu-devel] [PATCH 04/36] monitor: use qapi for qmp_capabilities command,
Eric Blake <=
- [Qemu-devel] [PATCH 07/36] qapi: add some headings in docs, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 10/36] texi2pod: learn quotation, deftp and deftypefn, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 08/36] qapi: add qapi2texi script, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 11/36] build-sys: generate QAPI doc based on json, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 12/36] build-sys: generate qmp-commands.txt, marcandre . lureau, 2015/09/25
- [Qemu-devel] [PATCH 09/36] qapi: remove qmp-events.txt, marcandre . lureau, 2015/09/25