[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/36] texi2pod: learn quotation, deftp and deft

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 10/36] texi2pod: learn quotation, deftp and deftypefn
Date: Fri, 25 Sep 2015 09:44:40 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 09/25/2015 08:03 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
> Learn a few more markups used for API documentation.
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  scripts/texi2pod.pl | 44 +++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 43 insertions(+), 1 deletion(-)

This file was originally from gcc (we forked it from a point before gcc
upstream made theirs GPLv3).  Are your additions written from scratch,
or are they copied from somewhere else like gcc? Might be nice to be
explicit in your commit message.

I'm not the best perl reviewer, but the obvious test is whether the
resulting output file looks clean; offhand that seems to be the case,
but I'm not confident enough to leave R-b on this pass of reviews.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]