[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/32] acpi: add aml_create_field
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/32] acpi: add aml_create_field |
Date: |
Tue, 13 Oct 2015 14:38:22 +0200 |
On Sun, 11 Oct 2015 11:52:35 +0800
Xiao Guangrong <address@hidden> wrote:
> Implement CreateField term which is used by NVDIMM _DSM method in later patch
>
> Signed-off-by: Xiao Guangrong <address@hidden>
> ---
> hw/acpi/aml-build.c | 13 +++++++++++++
> include/hw/acpi/aml-build.h | 1 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index a72214d..9fe5e7b 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -1151,6 +1151,19 @@ Aml *aml_sizeof(Aml *arg)
> return var;
> }
>
> +/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateField */
> +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name)
you haven't addressed v2 comment wrt index, len
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00435.html
> +{
> + Aml *var = aml_alloc();
> + build_append_byte(var->buf, 0x5B); /* ExtOpPrefix */
> + build_append_byte(var->buf, 0x13); /* CreateFieldOp */
> + aml_append(var, srcbuf);
> + aml_append(var, index);
> + aml_append(var, len);
> + build_append_namestring(var->buf, "%s", name);
> + return var;
> +}
> +
> void
> build_header(GArray *linker, GArray *table_data,
> AcpiTableHeader *h, const char *sig, int len, uint8_t rev)
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 7296efb..7e1c43b 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -276,6 +276,7 @@ Aml *aml_touuid(const char *uuid);
> Aml *aml_unicode(const char *str);
> Aml *aml_derefof(Aml *arg);
> Aml *aml_sizeof(Aml *arg);
> +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name);
>
> void
> build_header(GArray *linker, GArray *table_data,
- Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM, (continued)
- Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM, Dan Williams, 2015/10/10
- Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM, Xiao Guangrong, 2015/10/12
- Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM, Dan Williams, 2015/10/12
- Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM, Xiao Guangrong, 2015/10/12
- Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM, Dan Williams, 2015/10/13
- Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM, Xiao Guangrong, 2015/10/13
- Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM, Dan Williams, 2015/10/13
- Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM, Xiao Guangrong, 2015/10/14
- Re: [Qemu-devel] [PATCH v3 00/32] implement vNVDIMM, Dan Williams, 2015/10/14
[Qemu-devel] [PATCH v3 03/32] acpi: add aml_create_field, Xiao Guangrong, 2015/10/10
- Re: [Qemu-devel] [PATCH v3 03/32] acpi: add aml_create_field,
Igor Mammedov <=
[Qemu-devel] [PATCH v3 14/32] pc-dimm: drop the prefix of pc-dimm, Xiao Guangrong, 2015/10/10
[Qemu-devel] [PATCH v3 04/32] acpi: add aml_mutex, aml_acquire, aml_release, Xiao Guangrong, 2015/10/10
[Qemu-devel] [PATCH v3 10/32] hostmem-file: clean up memory allocation, Xiao Guangrong, 2015/10/10
[Qemu-devel] [PATCH v3 12/32] pc-dimm: remove DEFAULT_PC_DIMMSIZE, Xiao Guangrong, 2015/10/10
[Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI, Xiao Guangrong, 2015/10/10