[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly |
Date: |
Mon, 12 Oct 2015 14:07:35 +0200 |
User-agent: |
Mutt/1.5.23.1 (2014-03-12) |
On Mon, Oct 12, 2015 at 10:00:19AM +0300, Pavel Fedin wrote:
> Hello!
>
> > Before this patch it would complain that the requested
> > number of cpus was greater than 123, but for gicv2 configs, it
> > should complain that the number is greater than 8.
>
> Actually, gicv2 code has own check, and it would complain about >8 CPU (see
> arm_gic_common_realize()).
It only gets a chance to do that check if the class init check doesn't
fail first, i.e. nr_cpus > 8 <= 123 will fail with a "> 8" message, but
nr_cpus > 123, as I wrote above, will fail with a "> 123" message.
drew
>
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
>
>
>