[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 2/2] snapshot: create bdrv_snapshot_all_del_
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH RFC 2/2] snapshot: create bdrv_snapshot_all_del_snapshot helper |
Date: |
Wed, 04 Nov 2015 13:10:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Denis V. Lunev" <address@hidden> wrote:
> to delete snapshots from all loaded block drivers.
>
> The patch also ensures proper locking.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Juan Quintela <address@hidden>
> ---
> block/snapshot.c | 27 ++++++++++++++++++++++++
> include/block/snapshot.h | 2 ++
> migration/savevm.c | 54
> +++++++++---------------------------------------
> 3 files changed, 39 insertions(+), 44 deletions(-)
>
> diff --git a/block/snapshot.c b/block/snapshot.c
> index 6b5ce4e..9d1aa9b 100644
> --- a/block/snapshot.c
> +++ b/block/snapshot.c
> @@ -391,3 +391,30 @@ bool bdrv_snapshot_all_can_snapshot(BlockDriverState
> **first_bad_bs)
> *first_bad_bs = NULL;
> return true;
> }
> +
> +int bdrv_snapshot_all_del_snapshot(const char *name,
bdrv_snapshot_delete_all?
bdrv_snapshot_delete_all_snapshots?
Agreed with the patches.
Reviewed-by: Juan Quintela <address@hidden>
- [Qemu-devel] [PATCH QEMU 2.5 v4 0/10] dataplane snapshot fixes + aio_poll fixes, Denis V. Lunev, 2015/11/03
- [Qemu-devel] [PATCH 03/10] migration: added missed aio_context_acquire around bdrv_snapshot_delete, Denis V. Lunev, 2015/11/03
- Re: [Qemu-devel] [PATCH 03/10] migration: added missed aio_context_acquire around bdrv_snapshot_delete, Juan Quintela, 2015/11/03
- [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, Denis V. Lunev, 2015/11/04
- Re: [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, Juan Quintela, 2015/11/04
- Re: [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, Denis V. Lunev, 2015/11/04
- Re: [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, Juan Quintela, 2015/11/04
- Re: [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH RFC 1/2] snapshot: create helper to test that block drivers supports snapshots, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH RFC 2/2] snapshot: create bdrv_snapshot_all_del_snapshot helper, Denis V. Lunev, 2015/11/04
- Re: [Qemu-devel] [PATCH RFC 2/2] snapshot: create bdrv_snapshot_all_del_snapshot helper,
Juan Quintela <=
- Re: [Qemu-devel] [PATCH RFC 1/2] snapshot: create helper to test that block drivers supports snapshots, Juan Quintela, 2015/11/04
- Re: [Qemu-devel] [PATCH RFC 1/2] snapshot: create helper to test that block drivers supports snapshots, Stefan Hajnoczi, 2015/11/04
- Re: [Qemu-devel] [PATCH RFC 1/2] snapshot: create helper to test that block drivers supports snapshots, Stefan Hajnoczi, 2015/11/04
[Qemu-devel] [PATCH 07/10] block: call aio_context_acquire in qemu_img/nbd/io, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 01/10] migration: add missed aio_context_acquire for state writing/reading, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 02/10] block: add missed aio_context_acquire around bdrv_set_aio_context, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 04/10] blockdev: acquire AioContext in hmp_commit(), Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 05/10] block: guard bdrv_drain in bdrv_close with aio_context_acquire, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 08/10] fifolock: create rfifolock_is_owner helper, Denis V. Lunev, 2015/11/03