[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 1/2] snapshot: create helper to test that bl
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH RFC 1/2] snapshot: create helper to test that block drivers supports snapshots |
Date: |
Wed, 4 Nov 2015 13:52:06 +0000 |
User-agent: |
Mutt/1.5.23 (2015-06-09) |
On Wed, Nov 04, 2015 at 02:31:55PM +0300, Denis V. Lunev wrote:
> The patch enforces proper locking for this operation.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Juan Quintela <address@hidden>
> ---
> Patches are compile-tested only. Sent to check the approach, naming and
> functions placement. Functions are returning bad BlockDriver via
> parameter to make clear distinction when I'll have to return BS to write.
>
> block/snapshot.c | 35 +++++++++++++++++++++++++++++++++++
> include/block/snapshot.h | 9 +++++++++
> migration/savevm.c | 17 ++++-------------
> 3 files changed, 48 insertions(+), 13 deletions(-)
Kevin is the maintainer of block/snapshot.c. Please include him in
future revisions.
Looks fine to me, besides the comments that Juan already raised.
Stefan
- [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, (continued)
- [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, Denis V. Lunev, 2015/11/04
- Re: [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, Juan Quintela, 2015/11/04
- Re: [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, Denis V. Lunev, 2015/11/04
- Re: [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, Juan Quintela, 2015/11/04
- Re: [Qemu-devel] [RFC PATCH 1/1] dataplane: alternative approach to locking, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH RFC 1/2] snapshot: create helper to test that block drivers supports snapshots, Denis V. Lunev, 2015/11/04
- [Qemu-devel] [PATCH RFC 2/2] snapshot: create bdrv_snapshot_all_del_snapshot helper, Denis V. Lunev, 2015/11/04
- Re: [Qemu-devel] [PATCH RFC 2/2] snapshot: create bdrv_snapshot_all_del_snapshot helper, Juan Quintela, 2015/11/04
- Re: [Qemu-devel] [PATCH RFC 1/2] snapshot: create helper to test that block drivers supports snapshots, Juan Quintela, 2015/11/04
- Re: [Qemu-devel] [PATCH RFC 1/2] snapshot: create helper to test that block drivers supports snapshots, Stefan Hajnoczi, 2015/11/04
- Re: [Qemu-devel] [PATCH RFC 1/2] snapshot: create helper to test that block drivers supports snapshots,
Stefan Hajnoczi <=
[Qemu-devel] [PATCH 07/10] block: call aio_context_acquire in qemu_img/nbd/io, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 01/10] migration: add missed aio_context_acquire for state writing/reading, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 02/10] block: add missed aio_context_acquire around bdrv_set_aio_context, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 04/10] blockdev: acquire AioContext in hmp_commit(), Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 05/10] block: guard bdrv_drain in bdrv_close with aio_context_acquire, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 08/10] fifolock: create rfifolock_is_owner helper, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 10/10] aio: change aio_poll constraints, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 09/10] aio_context: create aio_context_is_owner helper, Denis V. Lunev, 2015/11/03
[Qemu-devel] [PATCH 06/10] io: guard aio_poll with aio_context_acquire, Denis V. Lunev, 2015/11/03