[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/24] hw/input/tsc210x: Remove superfluous memset
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 08/24] hw/input/tsc210x: Remove superfluous memset |
Date: |
Fri, 6 Nov 2015 15:43:45 +0300 |
From: Thomas Huth <address@hidden>
g_malloc0 already clears the memory, so no need for additional
memsets here. And while we're at it, let's also remove the
superfluous typecasts for the return values of g_malloc0
and use the type-safe g_new0 instead.
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/input/tsc210x.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/input/tsc210x.c b/hw/input/tsc210x.c
index fae3385..1073bbf 100644
--- a/hw/input/tsc210x.c
+++ b/hw/input/tsc210x.c
@@ -1086,9 +1086,7 @@ uWireSlave *tsc2102_init(qemu_irq pint)
{
TSC210xState *s;
- s = (TSC210xState *)
- g_malloc0(sizeof(TSC210xState));
- memset(s, 0, sizeof(TSC210xState));
+ s = g_new0(TSC210xState, 1);
s->x = 160;
s->y = 160;
s->pressure = 0;
@@ -1135,9 +1133,7 @@ uWireSlave *tsc2301_init(qemu_irq penirq, qemu_irq kbirq,
qemu_irq dav)
{
TSC210xState *s;
- s = (TSC210xState *)
- g_malloc0(sizeof(TSC210xState));
- memset(s, 0, sizeof(TSC210xState));
+ s = g_new0(TSC210xState, 1);
s->x = 400;
s->y = 240;
s->pressure = 0;
--
2.1.4
- [Qemu-devel] [PULL 00/24] Trivial patches for 2015-11-06, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 09/24] tests/i44fx-test: No need for zeroing memory before memset, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 10/24] linux-user/syscall: Replace g_malloc0 + memcpy with g_memdup, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 01/24] hw/acpi/aml-build: remove useless glib version check, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 06/24] tests: ignore test-qga, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 08/24] hw/input/tsc210x: Remove superfluous memset,
Michael Tokarev <=
- [Qemu-devel] [PULL 11/24] hw/dma/pxa2xx: Remove superfluous memset, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 02/24] gdbstub: Fix buffer overflows in gdb_handle_packet(), Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 23/24] qemu-sockets: do not test path with access() before unlinking, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 20/24] target-alpha: fix uninitialized variable, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 17/24] qom/object: fix 2 comment typos, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 16/24] configure: remove help string for 'vnc-tls' option, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 03/24] hw/display/tcx: Remove superfluous OBJECT() typecasts, Michael Tokarev, 2015/11/06