[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 10/24] linux-user/syscall: Replace g_malloc0 + memcpy
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 10/24] linux-user/syscall: Replace g_malloc0 + memcpy with g_memdup |
Date: |
Fri, 6 Nov 2015 15:43:47 +0300 |
From: Thomas Huth <address@hidden>
No need to use g_malloc0 to zero the memory if we memcpy to
the whole buffer afterwards anyway. Actually, there is even
a function which combines both steps, g_memdup, so let's use
this function here instead.
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
linux-user/syscall.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 8bfb24f..6c64ba6 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5325,8 +5325,7 @@ static abi_long do_open_by_handle_at(abi_long mount_fd,
abi_long handle,
return -TARGET_EFAULT;
}
- fh = g_malloc0(total_size);
- memcpy(fh, target_fh, total_size);
+ fh = g_memdup(target_fh, total_size);
fh->handle_bytes = size;
fh->handle_type = tswap32(target_fh->handle_type);
--
2.1.4
- [Qemu-devel] [PULL 00/24] Trivial patches for 2015-11-06, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 09/24] tests/i44fx-test: No need for zeroing memory before memset, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 10/24] linux-user/syscall: Replace g_malloc0 + memcpy with g_memdup,
Michael Tokarev <=
- [Qemu-devel] [PULL 01/24] hw/acpi/aml-build: remove useless glib version check, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 06/24] tests: ignore test-qga, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 08/24] hw/input/tsc210x: Remove superfluous memset, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 11/24] hw/dma/pxa2xx: Remove superfluous memset, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 02/24] gdbstub: Fix buffer overflows in gdb_handle_packet(), Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 23/24] qemu-sockets: do not test path with access() before unlinking, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 20/24] target-alpha: fix uninitialized variable, Michael Tokarev, 2015/11/06
- [Qemu-devel] [PULL 17/24] qom/object: fix 2 comment typos, Michael Tokarev, 2015/11/06