Re: [Qemu-devel] [PATCH 2/4] target-tilegx: Implement fpu single floating point

[Chen Gang]

On 11/13/15 00:18, Richard Henderson wrote:
> On 11/12/2015 05:12 PM, Chen Gang wrote:
>> On 11/12/15 22:36, Richard Henderson wrote:
>>>> +    if (sfmt.calc == TILEGX_F_CALC_CVT) {
>>>> +        if (sfmt.sign)
>>>> +            f.f = int32_to_float32(0 - sfmt.mantissa, fp_status);
>>>> +        else
>>>> +            f.f = uint32_to_float32(sfmt.mantissa, fp_status);
>>>> +    } else {
>>>
>>> Formatting.
>>>
>>> You really should know better by now.
>>> I'm not even going to look at the rest.
>>>
>>
>> Excuse me, my English is not quite well, I am not quite understand your
>> meaning.
>>
>> Does the code above have issues?
>>
> 
> Please read ./CODING_STYLE, and use ./scripts/checkpatch.pl.
> 

Oh, sorry.



Thanks.
-- 
Chen Gang (陈刚)

Open, share, and attitude like air, water, and life which God blessed