[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/77] ppc: Do some batching of TCG t
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/77] ppc: Do some batching of TCG tlb flushes |
Date: |
Mon, 16 Nov 2015 21:16:08 +1100 |
On Mon, 2015-11-16 at 16:00 +1100, David Gibson wrote:
>
> > //#define DEBUG_MMU
> > //#define DEBUG_BATS
> > @@ -1940,6 +1941,7 @@ void ppc_tlb_invalidate_all(CPUPPCState *env)
> > case POWERPC_MMU_2_03:
> > case POWERPC_MMU_2_06:
> > case POWERPC_MMU_2_07:
> > + env->tlb_need_flush = 0;
> > #endif /* defined(TARGET_PPC64) */
> > tlb_flush(CPU(cpu), 1);
> > break;
>
> Any particular reason you're leaving this one as an immediate rather
> than deferred flush?
A couple yes. It's mostly unused on server CPUs (we don't do tlbia),
and it's used by ppc_cpu_reset(). In that latter case, I like having
everything really cleaned up ...
> Should you be clearing the pending flush flag cpu_reset()?
That should happen as a result of the above.
Cheers,
Ben.
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/77] ppc: Use split I/D mmu modes to avoid flushes on interrupts, (continued)
[Qemu-devel] [PATCH 05/77] ppc: Update SPR definitions, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 11/77] ppc: Create cpu_ppc_set_papr() helper, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 12/77] ppc: Better figure out if processor has HV mode, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 03/77] ppc: Do some batching of TCG tlb flushes, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 09/77] ppc: Fix do_rfi() for rfi emulation, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 08/77] ppc: Add number of threads per core to the processor definition, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 06/77] ppc: Add macros to register hypervisor mode SPRs, Benjamin Herrenschmidt, 2015/11/10