[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] vmxnet3: The vmxnet3 device is a PCIE endpo
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] vmxnet3: The vmxnet3 device is a PCIE endpoint |
Date: |
Wed, 25 Nov 2015 16:24:39 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/25/2015 02:18 PM, Shmulik Ladkani wrote:
> Thanks Jason,
>
> On Wed, 25 Nov 2015 10:38:51 +0800, address@hidden wrote:
>>> @@ -2568,6 +2572,7 @@ static void vmxnet3_class_init(ObjectClass *class,
>>> void *data)
>>> c->class_id = PCI_CLASS_NETWORK_ETHERNET;
>>> c->subsystem_vendor_id = PCI_VENDOR_ID_VMWARE;
>>> c->subsystem_id = PCI_DEVICE_ID_VMWARE_VMXNET3;
>>> + c->is_express = 1;
>> Should we do this conditionally? And how about the migration
>> compatibility? Looks like pcie device is using vmstate_pcie_device
>> instead of vmstate_pci_device, maybe need a new property bit for this.
> (Responding for the entire series)
>
> Agreed. Will limit these changes for new versions.
>
> What's your suggested plan?
> Does it make sense to have a property for each change (as they are not
> necessarily related), or is it too tedious and one property will suffice?
Since they are not necessarily related, we'd better use a property for
each change.
Thanks
>
> Regards,
> Shmulik
>
[Qemu-devel] [PATCH 2/4] vmxnet3: Change offsets of PCI capabilities, Shmulik Ladkani, 2015/11/19
[Qemu-devel] [PATCH 3/4] vmxnet3: Change the offset of the MSIX PBA table, Shmulik Ladkani, 2015/11/19
[Qemu-devel] [PATCH 4/4] vmxnet3: Report the Device Serial Number capability, Shmulik Ladkani, 2015/11/19