[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] vmxnet3: The vmxnet3 device is a PCIE endpo
From: |
Shmulik Ladkani |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] vmxnet3: The vmxnet3 device is a PCIE endpoint |
Date: |
Sun, 29 Nov 2015 23:07:55 +0200 |
Hi,
On Wed, 25 Nov 2015 16:24:39 +0800 Jason Wang <address@hidden> wrote:
> >>> @@ -2568,6 +2572,7 @@ static void vmxnet3_class_init(ObjectClass *class,
> >>> void *data)
> >>> c->class_id = PCI_CLASS_NETWORK_ETHERNET;
> >>> c->subsystem_vendor_id = PCI_VENDOR_ID_VMWARE;
> >>> c->subsystem_id = PCI_DEVICE_ID_VMWARE_VMXNET3;
> >>> + c->is_express = 1;
> >> Should we do this conditionally? And how about the migration
> >> compatibility? Looks like pcie device is using vmstate_pcie_device
> >> instead of vmstate_pci_device, maybe need a new property bit for this.
> > (Responding for the entire series)
> >
> > Agreed. Will limit these changes for new versions.
> >
> > What's your suggested plan?
> > Does it make sense to have a property for each change (as they are not
> > necessarily related), or is it too tedious and one property will suffice?
>
> Since they are not necessarily related, we'd better use a property for
> each change.
Would it make sense if we expose a new vmxnet3 type to differenciate
pcie vs pci instances of vmxnet3?
Otherwise, migration gets more complicated, as we need to use either
vmstate_pci_device or vmstate_pcie_device; also, upon vm load, we need
to preserve the semantics saved (whether the instance was pci or pcie).
I have managed to do so, but is a bit tedious; Exposing a new type seems
cleaner.
[Qemu-devel] [PATCH 2/4] vmxnet3: Change offsets of PCI capabilities, Shmulik Ladkani, 2015/11/19
[Qemu-devel] [PATCH 3/4] vmxnet3: Change the offset of the MSIX PBA table, Shmulik Ladkani, 2015/11/19
[Qemu-devel] [PATCH 4/4] vmxnet3: Report the Device Serial Number capability, Shmulik Ladkani, 2015/11/19