[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/9] Revert "vhost: send SET_VRING_ENABLE at start/st
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 7/9] Revert "vhost: send SET_VRING_ENABLE at start/stop" |
Date: |
Thu, 26 Nov 2015 18:44:24 +0200 |
This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76.
In case of live migration several queues can be enabled and not only the
first one. So informing backend that only the first queue is enabled is
wrong.
Reported-by: Thibaut Collet <address@hidden>
Cc: Yuanhan Liu <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Yuanhan Liu <address@hidden>
---
hw/virtio/vhost.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 1794f0d..de29968 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -1226,11 +1226,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice
*vdev)
}
}
- if (hdev->vhost_ops->vhost_set_vring_enable) {
- /* only enable first vq pair by default */
- hdev->vhost_ops->vhost_set_vring_enable(hdev, hdev->vq_index == 0);
- }
-
return 0;
fail_log:
vhost_log_put(hdev, false);
@@ -1261,10 +1256,6 @@ void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice
*vdev)
hdev->vq_index + i);
}
- if (hdev->vhost_ops->vhost_set_vring_enable) {
- hdev->vhost_ops->vhost_set_vring_enable(hdev, 0);
- }
-
vhost_log_put(hdev, true);
hdev->started = false;
hdev->log = NULL;
--
MST
- [Qemu-devel] [PULL 0/9] vhost, pc: fixes for 2.5, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 1/9] osdep: Change default value of qemu_hw_version() to "2.5+", Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 2/9] pc: Don't set hw_version on pc-*-2.5, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 3/9] vhost-user: set link down when the char device is closed, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 4/9] vhost-user: clarify start and enable, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 5/9] tests/vhost-user-bridge: propose GUEST_ANNOUNCE feature, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 6/9] tests/vhost-user-bridge: read command line arguments, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 7/9] Revert "vhost: send SET_VRING_ENABLE at start/stop",
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 9/9] vhost-user-test: fix migration overlap test, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 8/9] Fix memory leak on error, Michael S. Tsirkin, 2015/11/26
- Re: [Qemu-devel] [PULL 0/9] vhost, pc: fixes for 2.5, Peter Maydell, 2015/11/26