[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 8/9] Fix memory leak on error
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 8/9] Fix memory leak on error |
Date: |
Thu, 26 Nov 2015 18:44:27 +0200 |
From: Stefano Dong (董兴水) <address@hidden>
hw/ppc/spapr.c: Fix memory leak on error, it was introduced in bc09e0611
hw/acpi/memory_hotplug.c: Fix memory leak on error, it was introduced in
34f2af3d
Signed-off-by: Stefano Dong (董兴水) <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/acpi/memory_hotplug.c | 1 +
hw/ppc/spapr.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
index ce428df..e4b9a01 100644
--- a/hw/acpi/memory_hotplug.c
+++ b/hw/acpi/memory_hotplug.c
@@ -155,6 +155,7 @@ static void acpi_memory_hotplug_write(void *opaque, hwaddr
addr, uint64_t data,
qapi_event_send_mem_unplug_error(dev->id,
error_get_pretty(local_err),
&error_abort);
+ error_free(local_err);
break;
}
trace_mhp_acpi_pc_dimm_deleted(mem_st->selector);
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 030ee35..3bb8bcd 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -125,6 +125,7 @@ static XICSState *xics_system_init(MachineState *machine,
error_report("kernel_irqchip requested but unavailable: %s",
error_get_pretty(err));
}
+ error_free(err);
}
if (!icp) {
--
MST
- [Qemu-devel] [PULL 0/9] vhost, pc: fixes for 2.5, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 1/9] osdep: Change default value of qemu_hw_version() to "2.5+", Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 2/9] pc: Don't set hw_version on pc-*-2.5, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 3/9] vhost-user: set link down when the char device is closed, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 4/9] vhost-user: clarify start and enable, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 5/9] tests/vhost-user-bridge: propose GUEST_ANNOUNCE feature, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 6/9] tests/vhost-user-bridge: read command line arguments, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 7/9] Revert "vhost: send SET_VRING_ENABLE at start/stop", Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 9/9] vhost-user-test: fix migration overlap test, Michael S. Tsirkin, 2015/11/26
- [Qemu-devel] [PULL 8/9] Fix memory leak on error,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PULL 0/9] vhost, pc: fixes for 2.5, Peter Maydell, 2015/11/26