[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] Xen PCI passthru: convert to realize()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] Xen PCI passthru: convert to realize() |
Date: |
Thu, 7 Jan 2016 09:53:32 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 01/07/2016 12:16 AM, Cao jin wrote:
>
>
> On 01/07/2016 12:07 AM, Eric Blake wrote:
>> On 01/05/2016 07:39 PM, Cao jin wrote:
> [...]
>>
>>> @@ -827,27 +827,26 @@ static int xen_pt_initfn(PCIDevice *d)
>>> xen_pt_config_init(s, &local_err);
>>> if (local_err) {
>>> error_append_hint(&local_err, "PCI Config space
>>> initialisation failed");
>>> - rc = -1;
>>> + error_propagate(errp, local_err);
>>> goto err_out;
>>> }
>>
>> Looks like this fixes a memory leak in an earlier patch; maybe you need
>> to shuffle hunks around?
>>
>
> Sorry, don`t quite undertand what "shuffle hunks around" means, could
> you detail it?
It means this change should occur in an earlier patch (probably 2/4?).
I shuffle hunks by using 'git rebase -i'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 2/4] Add Error **errp for xen_pt_setup_vga(), (continued)
[Qemu-devel] [PATCH v3 4/4] Xen PCI passthru: convert to realize(), Cao jin, 2016/01/05
[Qemu-devel] [PATCH v3 1/4] Add Error **errp for xen_host_pci_device_get(), Cao jin, 2016/01/05
Re: [Qemu-devel] [PATCH v3 0/4] Convert to realize(), Stefano Stabellini, 2016/01/06