[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/17] qapi: Drop useless 'data' member of union
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 07/17] qapi: Drop useless 'data' member of unions |
Date: |
Mon, 22 Feb 2016 10:39:02 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Feb 19, 2016 at 05:19:37PM -0700, Eric Blake wrote:
> Now that we no longer have any clients of the 'void *data'
> member injected into unions, we can drop it. Update the
> testsuite to drop the negative test union-clash-data, and
> replace it with a positive test in qapi-schema-test that
> proves that we no longer have a name collision.
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v1: drop patch that forced :empty as base to all structs
> Previously posted as part of qapi cleanup subset F:
> v6: rebase to earlier changes
> ---
> scripts/qapi-types.py | 9 ---------
> tests/Makefile | 1 -
> tests/qapi-schema/qapi-schema-test.json | 2 +-
> tests/qapi-schema/qapi-schema-test.out | 4 ++--
> tests/qapi-schema/union-clash-data.err | 0
> tests/qapi-schema/union-clash-data.exit | 1 -
> tests/qapi-schema/union-clash-data.json | 7 -------
> tests/qapi-schema/union-clash-data.out | 9 ---------
> 8 files changed, 3 insertions(+), 30 deletions(-)
> delete mode 100644 tests/qapi-schema/union-clash-data.err
> delete mode 100644 tests/qapi-schema/union-clash-data.exit
> delete mode 100644 tests/qapi-schema/union-clash-data.json
> delete mode 100644 tests/qapi-schema/union-clash-data.out
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH 00/17] qapi implicit types (continuing the qapi cleanup theme), Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 06/17] chardev: Drop useless ChardevDummy type, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 07/17] qapi: Drop useless 'data' member of unions, Eric Blake, 2016/02/19
- Re: [Qemu-devel] [PATCH 07/17] qapi: Drop useless 'data' member of unions,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH 02/17] chardev: Shorten references into ChardevBackend, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 08/17] qapi-visit: Factor out gen_visit_fields_call(), Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 10/17] qapi: Fix command with named empty argument type, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 09/17] qapi: Add type.is_empty() helper, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 15/17] qapi: Use anonymous base in SchemaInfo, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 13/17] qapi-visit: Move error check into gen_visit_fields_call(), Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 16/17] qapi: Use anonymous base in CpuInfo, Eric Blake, 2016/02/19
- [Qemu-devel] [PATCH 01/17] chardev: Properly initialize ChardevCommon components, Eric Blake, 2016/02/19